-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slo-controller: refactor codes for reading #1973
slo-controller: refactor codes for reading #1973
Conversation
e11de1d
to
abaeae0
Compare
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
abaeae0
to
09aa753
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1973 +/- ##
==========================================
- Coverage 67.56% 67.54% -0.02%
==========================================
Files 420 420
Lines 47059 47060 +1
==========================================
- Hits 31795 31787 -8
- Misses 12955 12960 +5
- Partials 2309 2313 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
we also have a |
It is in koordinator, the reason I won't elaborate here is to make it easier to understand. There will be a user document later to explain in detail some of the details and how to use it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Fansong Zeng <fanster.z@gmail.com> Signed-off-by: george <xiangzhihua@gmail.com>
Signed-off-by: Fansong Zeng <fanster.z@gmail.com> Signed-off-by: george <xiangzhihua@gmail.com>
Ⅰ. Describe what this PR does
Here we just adjusted the naming of the code and added a diagram to explain the calculation logic of Batch resources. The code logic has not been changed.